Stream: committers
Topic: Build failing -- not implemented, not needed?
David Pyke (Jun 30 2021 at 18:24):
org.apache.commons.lang3.NotImplementedException: Not implemented - not needed?
at org.hl7.fhir.tools.publisher.ExampleInspector.fetchesCanonicalResource(ExampleInspector.java:651)
at org.hl7.fhir.validation.instance.InstanceValidator.start(InstanceValidator.java:3985)
questionnaire-profile-example-ussg-fht:: questionnaire-profile-example-ussg-fht: Not implemented - not needed? at org.hl7.fhir.validation.instance.InstanceValidator.validateResource(InstanceValidator.java:5151)
at org.hl7.fhir.validation.instance.InstanceValidator.validateContains(InstanceValidator.java:4268)
at org.hl7.fhir.validation.instance.InstanceValidator.checkChildByDefinition(InstanceValidator.java:4572)
at org.hl7.fhir.validation.instance.InstanceValidator.checkChild(InstanceValidator.java:4423)
at org.hl7.fhir.validation.instance.InstanceValidator.validateElement(InstanceValidator.java:4375)
at org.hl7.fhir.validation.instance.InstanceValidator.startInner(InstanceValidator.java:4091)
at org.hl7.fhir.validation.instance.InstanceValidator.start(InstanceValidator.java:3959)
at org.hl7.fhir.validation.instance.InstanceValidator.validateResource(InstanceValidator.java:5151)
at org.hl7.fhir.validation.instance.InstanceValidator.validateContains(InstanceValidator.java:4268)
at org.hl7.fhir.validation.instance.InstanceValidator.checkChildByDefinition(InstanceValidator.java:4572)
at org.hl7.fhir.validation.instance.InstanceValidator.checkChild(InstanceValidator.java:4423)
at org.hl7.fhir.validation.instance.InstanceValidator.validateElement(InstanceValidator.java:4375)
at org.hl7.fhir.validation.instance.InstanceValidator.checkChildByDefinition(InstanceValidator.java:4589)
at org.hl7.fhir.validation.instance.InstanceValidator.checkChild(InstanceValidator.java:4423)
at org.hl7.fhir.validation.instance.InstanceValidator.validateElement(InstanceValidator.java:4375)
at org.hl7.fhir.validation.instance.InstanceValidator.startInner(InstanceValidator.java:4091)
at org.hl7.fhir.validation.instance.InstanceValidator.start(InstanceValidator.java:3959)
at org.hl7.fhir.validation.instance.InstanceValidator.validateResource(InstanceValidator.java:5151)
at org.hl7.fhir.validation.instance.InstanceValidator.validate(InstanceValidator.java:719)
at org.hl7.fhir.validation.instance.InstanceValidator.validate(InstanceValidator.java:692)
at org.hl7.fhir.tools.publisher.ExampleInspector.validateLogical(ExampleInspector.java:347)
at org.hl7.fhir.tools.publisher.ExampleInspector.doValidate(ExampleInspector.java:315)
at org.hl7.fhir.tools.publisher.ExampleInspector.validate(ExampleInspector.java:308)
at org.hl7.fhir.tools.publisher.Publisher.validationProcess(Publisher.java:5687)
at org.hl7.fhir.tools.publisher.Publisher.execute(Publisher.java:619)
at org.hl7.fhir.tools.publisher.Publisher.main(Publisher.java:474)
David Pyke (Jun 30 2021 at 18:25):
Not sure what to do about this. It's failing locally and on the CI
David Pyke (Jun 30 2021 at 18:25):
https://dev.azure.com/fhir-pipelines/fhir-publisher/_build/results?buildId=20210630.6
David Pyke (Jun 30 2021 at 18:38):
@Mark Iantorno ?
Mark Iantorno (Jun 30 2021 at 19:11):
I can look at it after 530
Grahame Grieve (Jun 30 2021 at 19:30):
well, obviously it is needed :-(
Mark Iantorno (Jun 30 2021 at 19:30):
I can get it Grahame, I'm just in a meeting now
Mark Iantorno (Jun 30 2021 at 19:30):
I bet it's just a dependency thing
Mark Iantorno (Jun 30 2021 at 19:30):
I am unsure why Master branch is failing though
David Pyke (Jun 30 2021 at 19:30):
I wiped out my .gradle and .fhir so, not sure what else I would need to do
Mark Iantorno (Jun 30 2021 at 19:31):
It is most likely not you because master is currently failing
Mark Iantorno (Jun 30 2021 at 19:31):
I need to look at master and see what's up
Mark Iantorno (Jun 30 2021 at 19:31):
But again, I'm in meetings until 530
Grahame Grieve (Jun 30 2021 at 19:40):
i bet it's not just a dependency thing. you'll have to fill out those empty implementations, once we figure out what is needed.
Mark Iantorno (Jun 30 2021 at 19:43):
Yeah, I think it's identical to the issue I fixed in that merge you had errors in last week.
Mark Iantorno (Jun 30 2021 at 21:26):
I'm looking at this now, trying to fix master first
Mark Iantorno (Jun 30 2021 at 21:27):
I may roll back the last commit if I feel it's causing the issue
Grahame Grieve (Jun 30 2021 at 21:29):
this is code I wrote recently, making kindling compile for updates to core. I didn't know whether it would need to be implemented properly, and ran out of time to check
Grahame Grieve (Jun 30 2021 at 21:29):
unless you plan to rollback changes in core - don't - then you'll need to implement that method
Mark Iantorno (Jun 30 2021 at 21:33):
yeah that's for the issue above
Mark Iantorno (Jun 30 2021 at 21:33):
I'm going to fix master first
Mark Iantorno (Jun 30 2021 at 21:33):
master is failing validation of resources, it looks like it was caused by the last merge
Mark Iantorno (Jun 30 2021 at 21:34):
I'm just testing it now
Mark Iantorno (Jun 30 2021 at 21:34):
if the last merge caused the issue, I'm going to roll it back and contact that person
Mark Iantorno (Jun 30 2021 at 21:36):
once master is building than I will address the issue above, without a baseline that works, I cannot figure out what is exactly breaking and if what I change will fix it
Mark Iantorno (Jun 30 2021 at 21:49):
So right now, the master branch is failing with:
Summary: Errors=1, Warnings=3590, Information messages=618
ERROR @ questionnaire-profile-example-ussg-fht: questionnaire-profile-example-ussg-fht:: questionnaire-profile-example-ussg-fht: Not implemented - not needed? (src = InstanceValidator)
This was a Full Build 2.098 900sec 1444MB
FHIR build failure @ Wed, Jun 30, 2021 17:48-0400 5.442 906sec 1444MB
Error: Resource Examples failed instance validation
org.hl7.fhir.tools.publisher.ExampleInspector$EValidationFailed: Resource Examples failed instance validation
at org.hl7.fhir.tools.publisher.ExampleInspector.summarise(ExampleInspector.java:421)
at org.hl7.fhir.tools.publisher.Publisher.validationProcess(Publisher.java:5730)
at org.hl7.fhir.tools.publisher.Publisher.execute(Publisher.java:619)
at org.hl7.fhir.tools.publisher.Publisher.main(Publisher.java:474)
> Task :publish FAILED
Mark Iantorno (Jun 30 2021 at 21:50):
This is consistent across the last few commits, so it has nothing to do with them
Grahame Grieve (Jun 30 2021 at 22:01):
so what changed? did you do a new release of kindling?
Mark Iantorno (Jun 30 2021 at 22:50):
Nothing had changed
Mark Iantorno (Jun 30 2021 at 22:51):
I just tried updating Kindling to the latest core, but that didn't fix it.
Mark Iantorno (Jun 30 2021 at 22:51):
Still getting the same validation error.
Mark Iantorno (Jun 30 2021 at 22:51):
I'm going to have to look at this more on Friday
Mark Iantorno (Jul 05 2021 at 13:44):
Alright, I'm back on this now. Was away Thursday and Friday.
Mark Iantorno (Jul 05 2021 at 18:46):
So, here's where I'm at with this:
Mark Iantorno (Jul 05 2021 at 18:47):
- This is the result of an external change, not a change within hl7/fhir or kindling.
Mark Iantorno (Jul 05 2021 at 18:48):
I can verify this by re-running previously passing builds on master for hl7/fhir, and seeing that they now fail as well.
Mark Iantorno (Jul 05 2021 at 18:49):
- Updating the kindling library to use the latest core/validator doesn't change anything in the resutls. I still get the same failing validation in on the same example
Mark Iantorno (Jul 05 2021 at 18:50):
- This example has been there a while, so I doubt this is a result of the example itself.
Mark Iantorno (Jul 05 2021 at 19:03):
Ah, I see what's causing it now
Mark Iantorno (Jul 05 2021 at 19:03):
https://github.com/HL7/kindling/commit/fce3fcc76ef0b797a97d04a8a6c6437fb74e670b
Mark Iantorno (Jul 05 2021 at 19:03):
It is kindling
Mark Iantorno (Jul 05 2021 at 19:04):
There was a change to throw a new NotImplementedException("Not implemented-not needed?") exception, instead of returning null in fetch canonical resource
Mark Iantorno (Jul 05 2021 at 19:04):
I"m going to roll that back to null for now to get the build working again
Mark Iantorno (Jul 05 2021 at 19:05):
This was in ExampleInsspector.java
Mark Iantorno (Jul 05 2021 at 19:45):
I have a fix going on
Mark Iantorno (Jul 05 2021 at 19:45):
https://github.com/HL7/fhir/pull/1301
Mark Iantorno (Jul 05 2021 at 19:45):
will be back to normal shortly
Grahame Grieve (Jul 05 2021 at 20:51):
that's not a fix, that's a hack. It's my fault, but it was meant to find out whether I needed to implement that, so now it needs implementing, which is, finding the canonical resource
Mark Iantorno (Jul 05 2021 at 20:51):
Yeah I just wanted to get it building again so people could commit.
David Pyke (Jul 06 2021 at 22:29):
So, do I resubmit my PR or has that been done?
Mark Iantorno (Jul 07 2021 at 12:56):
Yeah, you will have to. I don't usually resubmit PRs for people
Last updated: Apr 12 2022 at 19:14 UTC
