Stream: committers
Topic: Broken Search Expressions
Grahame Grieve (Aug 06 2018 at 01:02):
The following search expressions look broken to me:
- Device.extension(http://hl7.org/fhir/SearchParameter/device-extensions-Device-din)
- Observation.extension(Gene)
- Observation.extension(DNASequenceVariantName)
- Observation.extension(AminoAcidChangeName)
- Observation.extension(Gene, DNASequenceVariantName)
- Observation.extension(Gene, AminoAcidChangeName)
- DiagnosticReport.extension(AssessedCondition)
- Patient.extension(http://hl7.org/fhir/SearchParameter/patient-extensions-Patient-mothersMaidenName)
Eric Haas (Aug 06 2018 at 01:42):
correction that is DiagnosticReport.extension(geneticsAssessedCondition)
Gil Alterovitz (Aug 08 2018 at 00:29):
Jamie will be looking to solve this.
Ling Teng (Aug 08 2018 at 14:45):
we haven't solved this kind of problems before, any ideas?
Grahame Grieve (Aug 08 2018 at 20:00):
which one are you asking about?
Kevin Power (Aug 08 2018 at 20:05):
Ling is likely look at these:
Observation.extension(Gene)
Observation.extension(DNASequenceVariantName)
Observation.extension(AminoAcidChangeName)
Observation.extension(Gene, DNASequenceVariantName)
Observation.extension(Gene, AminoAcidChangeName)
DiagnosticReport.extension(AssessedCondition)
Grahame Grieve (Aug 08 2018 at 20:14):
so for these, the correct syntax is Observation.extension([url]), but "Gene" is not a URL
Grahame Grieve (Aug 08 2018 at 20:15):
it should be something like Observation.extension('http://hl7.org/fhir/StructureDefinition/observation-geneticsGene')
Grahame Grieve (Aug 08 2018 at 20:16):
I ca't guess at what 'Observation.extension(Gene, DNASequenceVariantName)' is trying to say
Kevin Power (Aug 08 2018 at 20:20):
Those are extensions, so likely wanting a single search expression for two fields (if that is valid or necessary)
Jamie Jones (Aug 08 2018 at 20:51):
Hi all, Jamie here:
Ling and I tried fixing them just like that, but they still looked the same to me on http://build.fhir.org/observation-genetic.html (blank path previews). Is that intended, with "Observation.extension('http://hl7.org/fhir/StructureDefinition/observation-geneticsGene')" in the xml as an expression and no xpath variable?
Fixing the URLs is simple for us to correct if that's all it takes--I just want to make sure the goal isn't to make them end up validating to align with the search parameters on http://build.fhir.org/codesystem-extensions.html, for example.
Thanks!
Grahame Grieve (Aug 08 2018 at 21:00):
so the ones for both extensions: Observation.extension(url) | Observation.extension(url)
Grahame Grieve (Aug 08 2018 at 21:01):
tried fixing them
how ?
Jamie Jones (Aug 08 2018 at 21:02):
We edited the observation-genetic-profile-spreadsheet xml file on a local build here with links
Jamie Jones (Aug 08 2018 at 21:03):
thanks for the tip on the compound searches!
Grahame Grieve (Aug 08 2018 at 21:06):
so you're saying that edited them locally, and then built locally, but the rendered guide didn't look different?
Jamie Jones (Aug 08 2018 at 21:09):
correct, though I'm double-checking syntax now and rebuilding to confirm
Grahame Grieve (Aug 08 2018 at 21:11):
I'm not actually sure where the search parameter appears in the spec at all....
Grahame Grieve (Aug 08 2018 at 21:11):
ah and then I found it immediately: http://build.fhir.org/observation-profiles.html
Grahame Grieve (Aug 08 2018 at 21:11):
should change at the bottom of the page
Jamie Jones (Aug 08 2018 at 21:15):
Ah okay, perfect. I was worried because they still show up as empty on the local copy of http://build.fhir.org/observation-genetic.html
Jamie Jones (Aug 08 2018 at 21:19):
Additionally, it looks like the "Observation.extension(url) | Observation.extension(url)" expressions show up on http://build.fhir.org/observation-profiles.html as just the second argument, I hope that's just the graphical representation
Grahame Grieve (Aug 08 2018 at 21:20):
'just the second argument'?
Jamie Jones (Aug 08 2018 at 21:21):
gene-dnavariant string HGNC gene symbol and HGVS DNA Variant
Expression: Observation.extension('http://hl7.org/fhir/StructureDefinition/observation-geneticsDnaVariant') for example, when the xml is
Observation.extension(http://hl7.org/fhir/StructureDefinition/observation-geneticsGene)|Observation.extension('http://hl7.org/fhir/StructureDefinition/observation-geneticsAminoAcidChangeName')
I'll try it with the middle spaces, that will probably fix it
Jamie Jones (Aug 08 2018 at 21:33):
Actually it appears with and without the spaces around the |, it's only picking up what's after the |, confirmed with the xml/json view of the search parameter. Not sure how to make | work at this point.
Thanks again for your help!
Grahame Grieve (Aug 08 2018 at 21:43):
hmm. commit with the source correct, and make a task for me to look at the presentation issue
Jamie Jones (Aug 09 2018 at 17:52):
I'm getting 31 tree conflicts after updating (I'm new to SVN and this would be my first commit). Want to make sure I don't cause anybody extra work in committing. Only source files I changed are the search expressions in diagnosticreport-genetics-profile-spreadsheet.xml and observation-genetics-profile-spreadsheet.xml
Jamie Jones (Aug 09 2018 at 18:18):
I tried performing a clean checkout to minimize conflicts with recent builds but keep getting truncated HTTP response body... is this normal?
Rob Hausam (Aug 09 2018 at 18:28):
I expect the tree conflicts are on vscache files? I just aways accept those as resolved, or if it asks "their side" (tc) or "my side (mc)" I select tc, and that should clear those up. Doing a fresh complete checkout sometimes does result in the truncated response. If you're in that situation and you can I think I would keep the truncated response and then update on top of that until it's complete (at least I think that's what I did the last time - that's been a good while back). That's my take, anyway.
Jamie Jones (Aug 09 2018 at 18:34):
Yes they are all vscache files, thanks for the insight. I get nervous with the truncated response automatically locking my working copy. It tells me to run cleanup then update to continue but the warnings listed in "svn help cleanup" worry me so I wanted to confirm
Lloyd McKenzie (Aug 09 2018 at 18:57):
Our project is bigger than SVN knows how to handle. If you keep cleaning up and updating you'll eventually get to success.
Jamie Jones (Aug 09 2018 at 19:53):
sounds good, thanks Lloyd
Last updated: Apr 12 2022 at 19:14 UTC
