Stream: committers
Topic: Breaking build changes
Eric Haas (May 24 2017 at 18:33):
I will be removing the DataElement resource from the build hopefully later today. in the near future, I will also be removing ReferralRequest and merging it with ProcedureRequest ( We have not landed on a name for this yet so will be call ProcedureRequest at least for now ). So plan accordingly...
Grahame Grieve (May 24 2017 at 19:27):
Eric: removing DataElement from the build will be complex, because the build itself depends on DataElement
Grahame Grieve (May 24 2017 at 19:28):
I think you better leave it to me to actually remove it; just edit everything that refers to it so it's an orphan, and I'll actually remove it
Eric Haas (May 24 2017 at 19:32):
OK I've already removed all the html references to it thoughout the build and was going through the elementdefinition profiles right now to remove the references and move the valuesets over. How about I do that and leave in fhir.ini and let you do the rest?
Eric Haas (May 24 2017 at 19:33):
I think that is what you meant by orphan
Grahame Grieve (May 24 2017 at 19:47):
yes pretty much. let me know when you're done, and I'll add it to my list
Eric Haas (May 24 2017 at 21:47):
@GG OK I removed as much as I could. still in:
fhir.ini
compartments.xml
status-codes.xml
heirarchy,xml
Eric Haas (May 25 2017 at 14:14):
FYI ReferralRequest has been merged with ProcedureRequest.
Brian Postlethwaite (May 31 2017 at 22:16):
referral replaced by procedure request seems weird to me. What was the tracker with the notes in it for the change?
(I'll have to revisist the notes in the PA resources - encounter, appointment and episodeofcare)
Christopher Schuler (May 31 2017 at 22:38):
I am getting the following error when committing opioid-cds IG:
Publishing Content Failed: Error parsing dataelements.xml:Unknown resource type DataElement (31.0827sec)
Not sure what to do... Tried updating the publisher jar in project to current, but that didn't help.
Grahame Grieve (May 31 2017 at 23:20):
what version is it?
Grahame Grieve (May 31 2017 at 23:21):
as in, what version is the IG?
Christopher Schuler (May 31 2017 at 23:22):
3.0.1
Grahame Grieve (May 31 2017 at 23:24):
hmm. it should work. is it in GitHub?
Christopher Schuler (May 31 2017 at 23:24):
https://github.com/cqframework/opioid-cds
Grahame Grieve (May 31 2017 at 23:25):
k I'll have a look
Christopher Schuler (May 31 2017 at 23:25):
Thank you Grahame
Lloyd McKenzie (Jun 01 2017 at 00:52):
Referral was replaced by ProcedureRequest
Eric Haas (Jun 01 2017 at 01:19):
I've updated most of the references to ReferalRequest to ProcedureRequest. but left referral as referral unless is talking about the resource and not the actions. The GForge is here. There was very little difference between them except the name really. GF#13196 and we haven't decided on a name so for now is still ProcedureRequest.
Grahame Grieve (Jun 01 2017 at 06:54):
@Christopher Schuler I fixed that problem (build 12068). There's another which I have not investigated on the grounds that the error message implies I can assume it's your problem ;-)
Christopher Schuler (Jun 01 2017 at 18:04):
Thanks @Grahame Grieve. However, I am still getting the error for 3.0.1... Moved to 3.1.0 and the IG is publishing successfully now.
Bryn Rhodes (Jun 01 2017 at 18:08):
I do note that the output says IG version is 12068, but gen-code version is 12051. Would that affect things?
Grahame Grieve (Jun 01 2017 at 20:45):
no.
Grahame Grieve (Jun 01 2017 at 21:20):
the generated code version relates to when I last updated the generated code running inside the IG publisher. That has to change when conformance resources change.
Grahame Grieve (Jun 01 2017 at 21:27):
@Lloyd McKenzie right now, all 3.0.1 IGs are broken because of the removal of DataElement. It's kind of a long chain of things:
- we changed from DataElement to a Logical Model StructureDefinition
- so I updated the generation code to generate logical models for each data element instead of data elements
- that meant that I had to stop generating data elements for entire resources
- then I updated the VersionConvertors to convert data elements to logical models
- the old versions still have data elements for entire resources
- these are overwriting the real resource declarations
Grahame Grieve (Jun 01 2017 at 21:28):
this is the 3rd issue I've found in the code caused by having logical models around. There's several possible approaches to pursue to resolve this (not mutually exclusive):
- add a new kind on StructureDefinition - DataElement (as well as logical)
- change the IG Loader to not load some or all data elements)
- move all the generated data element structure definitions to a different namespace
Lloyd McKenzie (Jun 01 2017 at 22:03):
@Grahame Grieve Understand the issue. Not sure if you are looking for an action, an answer or whether the directed message was just an FYI?
Grahame Grieve (Jun 01 2017 at 22:42):
opinions
Bryn Rhodes (Jun 01 2017 at 23:16):
What is the purpose of the DataElement structure definitions?
Lloyd McKenzie (Jun 02 2017 at 00:02):
@Bryn Rhodes Data Element's are logical descriptions of a single data "item" with the intended purpose of standardizing the capture, persistence and/or sharing of data. Most data elements have a simple data type, but occasionally they have more complicated structures. They're commonly used in the research space but in other areas. The ISO 11179 specification describes they're typical characteristics.
Lloyd McKenzie (Jun 02 2017 at 00:04):
@Grahame Grieve My leaning is that logical models and data elements are different things with different purposes and scopes, so having a new StructureDefinition type would be appropriate. However, it's hard to come up with firm boundaries. to deliniate the two. A couple of differences - A data element must have a definition at the root level. A logical model might not. A logical model will always have multiple elements, whereas data elements will often not. Beyond that, I'm not sure.
Grahame Grieve (Jun 02 2017 at 02:59):
ok. for now, just gave them a different URL. fixed
Grahame Grieve (Jun 02 2017 at 02:59):
one 12071 builds, that is
Christopher Schuler (Jun 02 2017 at 20:50):
I just confirmed that the 3.0.1 version of the cdc-opioid IG is publishing successfully. Thanks all.
Grahame Grieve (Jun 04 2017 at 04:10):
great
Christopher Schuler (Jun 05 2017 at 14:19):
Getting the following error when publishing ig:
org.hl7.fhir.r4.utils.client.EFhirClientException: Error sending Http Request: Connect to tx.fhir.org:80 timed out
I noticed @Brett Marquard is getting the same error when publishing... I am unsure how to resolve this one.
Christopher Schuler (Jun 05 2017 at 17:00):
Never mind... Seems to be working now.
Grahame Grieve (Jun 05 2017 at 23:53):
server was down for maintenance
Eric Haas (Jun 19 2017 at 22:51):
@Grahame Grieve can I mark GF#13094 as applied?
Grahame Grieve (Jun 19 2017 at 22:57):
yes
Last updated: Apr 12 2022 at 19:14 UTC
