FHIR Chat · Ballot Freeze · committers

Stream: committers

Topic: Ballot Freeze

Andy Stechishin (Aug 11 2018 at 03:12):

What time is the ballot freeze?

Lloyd McKenzie (Aug 11 2018 at 03:20):

Midnight-ish North American tomorrow for core content

Brian Postlethwaite (Aug 11 2018 at 03:21):

I thought it was in about 40 minutes, are you telling me I have another 24 hours?

Lloyd McKenzie (Aug 11 2018 at 03:22):

Grahame graciously extended it early this morning

Andy Stechishin (Aug 11 2018 at 03:46):

I guess I will end up owing Grahame a beer

Grahame Grieve (Aug 11 2018 at 03:48):

I'm not going to make it mysefl, and I'm not going to start post-freeze processing until about 7pm melbourne time Sunday evening

Brian Postlethwaite (Aug 11 2018 at 04:17):

That is a very civilized time of day (for us :grin: )

Grahame Grieve (Aug 11 2018 at 04:19):

we win 1 in 100 of the timezone things

Brian Postlethwaite (Aug 11 2018 at 04:21):

Not sure its event that often.

Grahame Grieve (Aug 12 2018 at 09:44):

ok. last call. Anyone still working?

Brian Postlethwaite (Aug 12 2018 at 10:32):

Didn't do the Source / SourceElement change on OperationDefinition?
(just testing the code gen with the latest version)
And http://hl7.org/fhir/ValueSet/device-status didn't end up in the Expansions.xml

Grahame Grieve (Aug 12 2018 at 10:36):

device status is a post freeze thing. I'll make the sourceelement change now

Brian Postlethwaite (Aug 12 2018 at 10:39):

Thanks, otherwise all good here.

Grahame Grieve (Aug 12 2018 at 10:43):

ok, so further commits to the core that are substantive now require my permission. That is, any changes that:
- involves a SHOULD or a SHALL
- any addition of a new example
- any change to a coded concept or any bindings
- any changes to structures other than patterns
- any changes to page list
- adding new extensions or changing types

(note that this list is partly about substantive for the build tools)

Grahame Grieve (Aug 12 2018 at 10:53):

@Brian Postlethwaite can you please review this list:

Grahame Grieve (Aug 12 2018 at 10:53):

http://build.fhir.org/ballot-intro.html#patient

Grahame Grieve (Aug 12 2018 at 10:54):

@Eric Haas @Rob Hausam please fill out this list: http://build.fhir.org/ballot-intro.html#observation

Brian Postlethwaite (Aug 12 2018 at 11:00):

Looks ok to me. The most significant change is the terminology code-system change

Grahame Grieve (Aug 12 2018 at 11:00):

That's the only substantiative change, right?

Brian Postlethwaite (Aug 12 2018 at 11:01):

From the last ballot, yes.

Grahame Grieve (Aug 12 2018 at 11:18):

thanks

Grahame Grieve (Aug 12 2018 at 12:17):

@Eric Haas @Rob Hausam What's the deal with DeviceDefinition.partOf?

Grahame Grieve (Aug 12 2018 at 12:25):

I have removed it - it looks like an error. I can't believe the tools didn't complain...

Drew Torres (Aug 12 2018 at 14:04):

@Brian Postlethwaite http://build.fhir.org/cm-administrative-gender-v2.html still looks incorrect. The Other mappings for V2 is missing the mapping to other as well. The double listing of v2 and v3 mappings look to have been corrected though.

Grahame Grieve (Aug 12 2018 at 14:05):

which exact mapping is missing

Drew Torres (Aug 12 2018 at 14:05):

other (Other) :wider A (Ambiguous)
Is missing Other under the v2 column.

Drew Torres (Aug 12 2018 at 14:06):

DSTU2: http://hl7.org/fhir/DSTU2/valueset-administrative-gender.html

Andy Stechishin (Aug 12 2018 at 20:39):

Is it permissible during the ballot freeze to update the placement of classes in the UML diagram?

Lloyd McKenzie (Aug 12 2018 at 20:53):

Grahame plans to spend a good bit of time doing exactly that. So long as you coordinate with him, I doubt he'd object to help...

Grahame Grieve (Aug 12 2018 at 20:56):

yes you can improve the UML diagrams.note this:

Grahame Grieve (Aug 12 2018 at 20:56):

https://chat.fhir.org/#narrow/stream/9-committers/subject/UML.20models

Andy Stechishin (Aug 12 2018 at 21:08):

My intention (if allowed) was to update the UML hints on the resource spreadsheet but I understand that it is difficult to verify that I changed nothing else beyond these values other than my word.

Andy Stechishin (Aug 12 2018 at 21:08):

I was hoping to work on the Contract UML diagram Monday evening (NA time)

Grahame Grieve (Aug 12 2018 at 23:09):

you can work on the UML diagrams no problems. I was suggesting that you consider the inkscape route for your convenience

Rob Hausam (Aug 12 2018 at 23:22):

Is there a suggested approach to filling out the http://build.fhir.org/ballot-intro.html#observation list?

Grahame Grieve (Aug 12 2018 at 23:24):

(1) you should first of review that the list of pages in the normative list is correct for Observation. if it's not, discuss with me

(2) for each page, review the delta, and make sure that for every substantive change since the last ballot, you know what task it came from

(3) for each task, make an entry in the list, with a short description of what changed, a link to the task, and links to the changed pages associated with the task. You can follow the template from infrastructure ballot notes

Rob Hausam (Aug 12 2018 at 23:33):

thanks - sounds like a bit of work to do
not sure what @Eric Haas's availability and plans are in the next few days, but will see about coordinating with him

Rob Hausam (Aug 13 2018 at 01:07):

Agree that DeviceDefinition.partOf isn't right - and it's still there. Are you going to remove it - or should we still fix it? DeviceDefinition is also not showing up in the Resource Index in the Categorized and Alphabetical tabs. @Eric Haas @Grahame Grieve

Eric Haas (Aug 13 2018 at 05:47):

Did not know about the list thing. will look at it tomorrow. I have not been part of the whole DeviceDefinition thing. Jose has committed all that. So I am no help there.

Grahame Grieve (Aug 13 2018 at 10:05):

I'll fix DeviceDefinition

Eric Haas (Aug 13 2018 at 22:43):

It has been brought to my attention that SupplyRequest claims to be part of the Patient compartment, but doesn't list search parameters for Patient (or Practitioner or Device or RelatedPerson). Is that something we should fix now or later?

Grahame Grieve (Aug 13 2018 at 22:48):

later

Lloyd McKenzie (Aug 13 2018 at 22:52):

What about Observation being part of the Practitioner and RelatedPerson compartments, but not having search criteria for either?

Grahame Grieve (Aug 13 2018 at 22:53):

I don't understand this - this is very thoroughly checked... at least I thought so

Lloyd McKenzie (Aug 13 2018 at 22:54):

Perhaps I don't understand the rules for compartments. I thought you needed an explicit search criteria for each compartment something is part of.

Grahame Grieve (Aug 13 2018 at 22:55):

indeed you do, and I increased the enforcement on this a couple of weeks ago

Eric Haas (Aug 13 2018 at 23:55):

Observation has several search parameters for Practitioner and RelatedPerson but the parameters are not exclusive to just Practitioner or RelatedPerson is that the issue here?

Grahame Grieve (Aug 14 2018 at 06:05):

GForge shows 2733 tasks applied to R4 since R3...

Grahame Grieve (Aug 14 2018 at 06:06):

597 to apply... wooah

Brian Postlethwaite (Aug 14 2018 at 11:59):

QA activities, normative page ValueSet - the first bit of text under the Normative candidate box looks like the editor assumed that the content here was markdown, but it hasn't been processed as such.
(The text just above 4.9.1 http://build.fhir.org/valueset.html#scope)

Brian Postlethwaite (Aug 14 2018 at 12:00):

It displays

Value sets link between [[[CodeSystem]]] definitions and their use in [coded elements](terminologies.html).

Rik Smithies (Aug 14 2018 at 15:32):

Some of the datatypes introduced in the last few cycles for use with medication and device definitions have never appeared on the datatypes page.

The only reason for this was technical difficulties on my part in getting them to display.

I've now figured out how to get them to show (I think). Is this something that I can fix in the build this week?

It's purely a publishing visibility thing and wouldn't mean any changes to any models or examples.

People are always asking why the links don't go anywhere...

Grahame Grieve (Aug 14 2018 at 18:25):

please describe what exact changes you have in mind

Andy Stechishin (Aug 14 2018 at 20:46):

I am almost ready to check-in UML diagram corrections, I am waiting on the full build to complete. I just want to verify that it is OK to commit a change where the only items changed are the values in the UML column of the spreadsheet for the resource

Grahame Grieve (Aug 14 2018 at 20:49):

yes

Grahame Grieve (Aug 14 2018 at 20:52):

which resources are you doing?

Andy Stechishin (Aug 14 2018 at 20:52):

Contract

Grahame Grieve (Aug 14 2018 at 20:52):

ok thx

Grahame Grieve (Aug 14 2018 at 20:52):

you didn't like the inkscape route?

Andy Stechishin (Aug 14 2018 at 20:53):

It was easy enough to use the values in the UML column which I have done before rather than downloading, installing and re-learning inkscape (which I haven't used in years)

Grahame Grieve (Aug 14 2018 at 20:54):

k

Andy Stechishin (Aug 14 2018 at 21:18):

So a bunch of vs-cache files changed, should those get checked in? All I did was change the UML layout on one resource.

Andy Stechishin (Aug 14 2018 at 21:25):

As well the vscache/null.cache was changed by the build, should this also be included in the check-in?

Grahame Grieve (Aug 14 2018 at 21:35):

yes always check in the .cache files if svn says they've changed

Andy Stechishin (Aug 14 2018 at 21:38):

Better to ask and verify rather than assume and break the rules

Grahame Grieve (Aug 14 2018 at 21:39):

sure

Rik Smithies (Aug 15 2018 at 10:16):

Re datatypes:

There are 5 datatypes, that were added in December 2017

MarketingStatus
ProductShelfLife
ProdCharacteristic
SubstanceAmount
SubstanceMoiety

These are small structures that are common to several resources in the medication and substance definition and, as of recently, device definition space.

Currently it is not possible to view the UML or structure tree or attribute descriptions of any of these.

The resource links go to the datatypes.html page, but then there is nothing there.

I plan to add the "templates" to the build\source\datatypes.html page, so the UML diagrams will appear. (e.g. [%dt ProductShelfLife 12%] etc)

When I tried to get that in originally in 2017 I just couldn’t get it to work.

Now it seems easier, and I have a local build that shows the details (no "tabs" show, however but that's a detail for later).

In the future, these datatypes may very well be subject to change, renaming, deletion etc. but that is a different issue.

This is just about surfacing what is already there – mending the broken links essentially.

This will also mean adding a "one line" basic description that doesn’t exist now, because the template has a space for that
(although in theory that could be left blank, and it would be no worse than it is now).

If this is considered too much clutter on datatypes.html then these could also have their own pages, similar to dosage.html (if I could work out how to do that).

Grahame Grieve (Aug 15 2018 at 10:17):

yes I don't want them in datatypes.html. given where we are, we go to ballot with things as that are, and we'll work on it after the ballot opens

Rik Smithies (Aug 15 2018 at 10:18):

ok will stand down then

Grahame Grieve (Aug 15 2018 at 11:13):

@Andy Stechishin :

just want to verify that it is OK to commit a change where the only items changed are the values in the UML column of the spreadsheet for the resource

Please explain this:

pasted image

Grahame Grieve (Aug 15 2018 at 11:21):

no. seems I should be asking svn to explain... sorry.

Grahame Grieve (Aug 16 2018 at 23:17):

Ballot schedule....

• the deadline for submitting content is end of day Aug 17
• but i won't start processing till Sunday evening my time
• the first thing I will process is the core build. And I need to get that one nailed immediately. So Sunday 7pm Australian eastern is a hard limit for changes to the core spec. it will go into full freeze at that time
• I should have that uploading sometime on Monday, giving me the rest of the week to work on he IGs.
• I have a hard deadline of noon Fri 24th Australian time. After that, I will be effectively gone for 48 hours or so.
• IG editors, I will be working with you on quality issues through next week

Lloyd McKenzie (Aug 16 2018 at 23:25):

For the rest of the world, Sunday evening Grahame's time is ~midnight pacific end of day Saturday, so you just got a day's grace.

Grahame Grieve (Aug 16 2018 at 23:26):

Lloyd, we still need to edit ballot-intro.html

Grahame Grieve (Aug 16 2018 at 23:27):

@Eric Haas @Rob Hausam what's the plan with regard to the substantive change list for observation

Grahame Grieve (Aug 16 2018 at 23:27):

as far as I know, these are the only open issues

Grahame Grieve (Aug 16 2018 at 23:35):

oh yes - and what did OO decide to do about Observation.context?

Rob Hausam (Aug 16 2018 at 23:36):

we approved the change to 'context'

Rob Hausam (Aug 16 2018 at 23:37):

I'm not sure what Eric is thinking regarding the open issues - I'll see about coordinating with him

Grahame Grieve (Aug 16 2018 at 23:38):

the change to context is pre-applied, yes?

Rob Hausam (Aug 16 2018 at 23:38):

yes - I've already changed fhir-ips accordingly

Eric Haas (Aug 17 2018 at 00:50):

I'm on it planning to generate it tonight. When I get back

Eric Haas (Aug 17 2018 at 00:51):

The substantive change list

Eric Haas (Aug 17 2018 at 00:52):

The context and extensions have been preapplied last week

Grahame Grieve (Aug 17 2018 at 00:57):

ok thanks

Eric Haas (Aug 17 2018 at 21:40):

@Grahame Grieve for observation we voted that the operations lastn and stats will be still be FMM5 so am going to remove from the normative page. OK?

Grahame Grieve (Aug 17 2018 at 21:41):

ok but how did you propose to do that?

Eric Haas (Aug 17 2018 at 21:43):

remove from this box:

Eric Haas (Aug 17 2018 at 21:43):

Screen-Shot-2018-08-17-at-2.43.00-PM.png

Grahame Grieve (Aug 17 2018 at 21:43):

.. which is auto-built. Removing it is more complicated than that

Eric Haas (Aug 17 2018 at 21:43):

and change the status to stu

Grahame Grieve (Aug 17 2018 at 21:44):

I'm removing it now

Eric Haas (Aug 17 2018 at 21:44):

OK I was going to update the spreadsheet are you doing that?

Grahame Grieve (Aug 17 2018 at 21:44):

y

Eric Haas (Aug 17 2018 at 21:44):

OK TY

Eric Haas (Aug 17 2018 at 21:51):

but do I edit the table on that page directly for changes?

Eric Haas (Aug 17 2018 at 21:51):

or is is all autobuilt?

Grahame Grieve (Aug 17 2018 at 21:52):

autobuilt

Eric Haas (Aug 17 2018 at 21:52):

so what is the format for this list?

Eric Haas (Aug 17 2018 at 21:52):

trying to create it now

Grahame Grieve (Aug 17 2018 at 21:53):

you can follow the format above, but a table with 3 columns:

• description
• task references
• page references

Eric Haas (Aug 17 2018 at 21:53):

what I meant is text, excel or html or md?

Grahame Grieve (Aug 17 2018 at 21:54):

html - see ballot-intro.html

Eric Haas (Aug 17 2018 at 21:54):

OK and do I send it to you or commit it as a file

Eric Haas (Aug 17 2018 at 21:56):

Screen-Shot-2018-08-17-at-2.55.59-PM.png

Grahame Grieve (Aug 17 2018 at 21:57):

you can commit

Eric Haas (Aug 17 2018 at 21:58):

OK great

Grahame Grieve (Aug 18 2018 at 02:22):

getting close on the main ballot.. waiting for @Eric Haas's change notes for Observation, and have to update history. And any more QA from @Rick Geimer - then we're ready to go into the publication slide, I think

Grahame Grieve (Aug 18 2018 at 02:22):

ah and one open discussion about narrative.

Eric Haas (Aug 18 2018 at 02:32):

just committed the substantive list

Rob Hausam (Aug 18 2018 at 02:40):

are you doing that now?
I do have an additional update for the snomed page and extensible binding section

Grahame Grieve (Aug 18 2018 at 02:41):

I'm not doing it now - close is still 30 hours away

Rob Hausam (Aug 18 2018 at 02:43):

that's what I thought - just sounded like you were saying something different!
I probably should get those done now and then come back to finishing up the IGs

Grahame Grieve (Aug 18 2018 at 02:43):

@Eric Haas - looking at the list, you've done the differences between R3 and R4 ballot 2, not between R4 ballot 1 and R4 ballot 2, yes?

Eric Haas (Aug 18 2018 at 03:02):

R3 and R4 ballot 2, not since the last ballot. Is that what you wanted?

Eric Haas (Aug 18 2018 at 03:02):

I'm confused between R3 and now.

Eric Haas (Aug 18 2018 at 03:02):

did you want since May?

Eric Haas (Aug 18 2018 at 03:27):

OK I'll go ahead an parse out the new stuff sorry

Grahame Grieve (Aug 18 2018 at 03:37):

well, let's not lose all the list - can you split it?

Bryn Rhodes (Aug 18 2018 at 03:54):

I assume we still need to officially submit by the content deadline? As in, an email to publishing with a link to the contents?

Grahame Grieve (Aug 18 2018 at 03:56):

I will handle that

Bryn Rhodes (Aug 18 2018 at 03:56):

Well, I mean for IGs.

Grahame Grieve (Aug 18 2018 at 03:57):

yes that. I will notify Lynn. Though it would be good for you to notify me formally by email that it's ready, and cc: Lynn

Bryn Rhodes (Aug 18 2018 at 03:57):

Okay, down to the last few errors on PDDI, will send when it's ready.

Bryn Rhodes (Aug 18 2018 at 03:57):

Thanks

Eric Haas (Aug 18 2018 at 04:00):

yes I saved and committed only the new stuff

Grahame Grieve (Aug 18 2018 at 04:00):

Al IG authors should review their change notes for updates of existing guides - I'll be paying careful attention to them. If you haven't written them in the IG itself, I will need them for the history. And review the description of the guide in the published history, and in http://www.fhir.org/guides/registry

if it's a new guide, check that that language in the IG proposal is still correct - I'll be using that for the history and the registry.

@Chris Moesel @Sarah Gaunt @Eric Haas @Lloyd McKenzie @Bryn Rhodes @Nagesh Bashyam @Rob Hausam @Stefan Karl

Sarah Gaunt (Aug 18 2018 at 04:02):

Do I need to do that - we are moving from for comment to stu...

Grahame Grieve (Aug 18 2018 at 04:03):

yes you need to do that

Sarah Gaunt (Aug 18 2018 at 04:03):

Where do I put them?

Sarah Gaunt (Aug 18 2018 at 04:03):

And I have until tomorrow 7pm still right?

Grahame Grieve (Aug 18 2018 at 04:03):

if you don't have a place, just send them to me by email.

Grahame Grieve (Aug 18 2018 at 04:04):

yes. maybe a bit longer for history notes.

Grahame Grieve (Aug 18 2018 at 04:04):

example:

Grahame Grieve (Aug 18 2018 at 04:04):

http://hl7.org/fhir/us/core/2018Jan/changelog.html

Grahame Grieve (Aug 18 2018 at 04:04):

another example:

Sarah Gaunt (Aug 18 2018 at 04:04):

Thanks

Grahame Grieve (Aug 18 2018 at 04:04):

http://hl7.org/fhir/us/sdc/changes.html#v2.0

Grahame Grieve (Aug 18 2018 at 04:05):

another example:

Rob Hausam (Aug 18 2018 at 04:05):

I was just going to ask about an example

Grahame Grieve (Aug 18 2018 at 04:05):

http://hl7.org/fhir/us/qicore/history.html

Grahame Grieve (Aug 18 2018 at 04:05):

so you can see we're flexible about style and location but there must be some

Sarah Gaunt (Aug 18 2018 at 04:05):

Ok - I can do something.. Will get it into my build so you don't have to worry about it.

Grahame Grieve (Aug 18 2018 at 04:06):

one other thing: if any guides are based on 3.4.0, they're about to go to 3.5.0 when I start the upgrade slide. make sure I have the rights to commit to them

Sarah Gaunt (Aug 18 2018 at 04:07):

And I'm going to be finished before 7pm tomorrow...

Lloyd McKenzie (Aug 18 2018 at 04:10):

CRD IG proposal updated so long description now reflects move to CDS Hooks.

Eric Haas (Aug 18 2018 at 08:30):

History files and changes logs sitting in the pages directory for deqm, degm-r4, I looked over the deqm ig proposal and is still inline but the and I updated the proposal to reflect the FHIR versions we are using now.

Grahame Grieve (Aug 18 2018 at 09:18):

ok thanks

Grahame Grieve (Aug 18 2018 at 09:19):

All right, I'm done with the core publication. All I have to do now is the upgrade, and then the publication run

Brian Postlethwaite (Aug 18 2018 at 09:22):

When does the version number change to 3.5? (the official build)

Grahame Grieve (Aug 18 2018 at 09:23):

I'll be doing that at 7pm-ish tomorrow. First, a full build. Then change the version. Then run again, then upgrade the java code, then run again. Then upgrade the tx server. Then blow the tx cache and run again. Then upgrade the code again. Then run again. Then upgrade the tx server, then blow the tx cache and then.... run again.... ;-)

Grahame Grieve (Aug 18 2018 at 09:24):

some day I'm going to have to figure out how to resolve all the circular dependencies (and in the meanwhile, hope that the intermediate hacked versions keep running so I can get through that sequence)

Grahame Grieve (Aug 18 2018 at 09:25):

the really great thing is, I get to do all that again when we go to 3.6.0 on the trunk

Brian Postlethwaite (Aug 18 2018 at 10:01):

The rewards ;)

Sarah Gaunt (Aug 18 2018 at 22:17):

@Grahame Grieve for the history page - for ECR what link should i be putting in for this ballot version - would it be: http://hl7.org/fhir/us/ecr/2018Sep/index.html?

Grahame Grieve (Aug 18 2018 at 22:24):

yes that's correct

Brian Postlethwaite (Aug 19 2018 at 03:42):

VhDir isn't currently listed in the IG registry, I think it should be, at least the CI Build.
(I guess I can make a pull request later)

Grahame Grieve (Aug 19 2018 at 03:42):

go ahead and make a pull request then

Sarah Gaunt (Aug 19 2018 at 04:14):

@Grahame Grieve - we are pretty much good to go with ECR. One more question though - do I need to remove the box with the CI build stuff:

pasted image

Or will you take care of that?

Grahame Grieve (Aug 19 2018 at 04:21):

I'll look after that

Sarah Gaunt (Aug 19 2018 at 04:27):

Thanks!

Sarah Gaunt (Aug 19 2018 at 05:21):

So for the eCR IG ballot I'm sending an email to you and Lynn - is that all I have to do?

Grahame Grieve (Aug 19 2018 at 05:22):

sure

Grahame Grieve (Aug 19 2018 at 06:59):

2 hours ;-)

Grahame Grieve (Aug 19 2018 at 09:05):

ok freeze is on

Grahame Grieve (Aug 19 2018 at 13:10):

ok. core is uploading to http://hl7.org/fhir/2018Sep. 39,135 files, 1.73GB

Grahame Grieve (Aug 19 2018 at 21:32):

ok tag is made, core is uploading, freeze is off

Brian Postlethwaite (Aug 20 2018 at 05:47):

The example json-edge-cases.json has invalid content in the core spec, shouldn't that be getting validated somewhere?

Grahame Grieve (Aug 20 2018 at 08:01):

what's invalid?

Brian Postlethwaite (Aug 20 2018 at 11:22):

The contained binary resource has a property called content, where it has been renamed to data in R4

Brian Postlethwaite (Aug 20 2018 at 11:23):

(the .net serializer picked it up)

Brian Postlethwaite (Aug 20 2018 at 11:24):

Also, heaps of examples don't roundtrip, search parameters don't all execute and invariant validations don't all work. Haven't chased them through to work out if its the .net fhirpath implementation and/or serilizer implementation yet.

Grahame Grieve (Aug 20 2018 at 11:47):

hmm yes that json file is a special case.

Grahame Grieve (Aug 20 2018 at 11:50):

can you make a task for me to validate that?

Grahame Grieve (Aug 20 2018 at 11:50):

what doesn't round trip?

Brian Postlethwaite (Aug 20 2018 at 11:50):

Sure.

Brian Postlethwaite (Aug 24 2018 at 02:17):

Reviewing through changes, I've noticed that the ElementDefinition page only has an R2 diff tab, not an R3 diff tab. I thought that was generated?
http://hl7.org/fhir/2018Sep/elementdefinition.html

Grahame Grieve (Aug 24 2018 at 02:19):

i've missed something - can you make a task?

Brian Postlethwaite (Aug 24 2018 at 02:19):

Fortunately I think the correct content is available here http://hl7.org/fhir/2018Sep/diff.html

Brian Postlethwaite (Aug 24 2018 at 02:19):

Sure.

Grahame Grieve (Aug 24 2018 at 02:19):

none of them are correct

Brian Postlethwaite (Aug 24 2018 at 02:19):

Bugger.

Brian Postlethwaite (Aug 24 2018 at 02:20):

Tooling or infrastructure?

Grahame Grieve (Aug 24 2018 at 02:23):

tooling

Brian Postlethwaite (Aug 24 2018 at 02:23):

done GF#17721

Grahame Grieve (Aug 24 2018 at 02:23):

see this note about the diffs: http://hl7.org/fhir/2018Sep/ballot-intro.html#round2

Brian Postlethwaite (Aug 24 2018 at 02:31):

Bad news on those diff links too.
try clicking on the diff link between ballots for ElementDefinition, the base url is wrong.
http://hl7.org/fhir/2018May/elementdefinition.html
http://hl7.fhir.org/fhir/2018Sep/elementdefinition.html

Brian Postlethwaite (Aug 29 2018 at 03:10):

@Grahame Grieve , that I mentioned here.

Andy Stechishin (Oct 11 2018 at 06:37):

Grahame, unfortunately I only saw this just now. Following the cut-off, I shut down Zulip to reduce the noise. My commit, following your approval would have only been the single xml file for the spreadsheet. I manually add the files that I commit on the commandline and am exceptionally careful not to commit additional file. You can verifyu this with the SVN commit logs (look at the individual commits which will show you the files that were commited). I go to great lengths to ensure that I follow the committer rules (as was evidenced by my requesting permission to perform the commit in question)

Grahame Grieve (Oct 11 2018 at 06:48):

this comment appears to several weeks old?

Andy Stechishin (Oct 11 2018 at 09:21):

no. seems I should be asking svn to explain... sorry.

@Grahame Grieve sorry, I saw the first because it mentioned me but I just saw this as I was walking through all the old messages

glad it was not an issue

Grahame Grieve (Oct 11 2018 at 09:21):

np

Lloyd McKenzie (Oct 11 2018 at 15:09):

@Andy Stechishin To help with the noise issue, we've created #committers/announce which will be low-volume high-importance stuff. You're free to ignore this stream and #committers/notification when you're not actively committing but should monitor (or plan to catch up and read all entries in before resuming commits) committers/announce

Andy Stechishin (Oct 11 2018 at 15:14):

I am subscribed to both, if I am not actively doing FHIR work then it does not make sense to have Zulip running. I have other feeds I need to follow and keep up-to-date on

Lloyd McKenzie (Oct 11 2018 at 15:38):

That's fine. It's just that if you start committing again, you need to actually read all of the content in committers/announce. Whereas you can just mark committers and committers/notification as "all read" without looking at them.

Last updated: Apr 12 2022 at 19:14 UTC