FHIR Chat · Adding critical information to a "change required" issue · committers

Stream: committers

Topic: Adding critical information to a "change required" issue


view this post on Zulip Paul Lynch (Mar 25 2020 at 19:32):

This subject came from https://chat.fhir.org/#narrow/stream/179255-questionnaire/topic/URI.20for.20answerExpression.3F. If a JIRA issue is resolved with "change required", but an important detail is left out about the specifics of the change that will made, what is the best way to get that added to ensure the change is made correctly?

view this post on Zulip Lloyd McKenzie (Mar 25 2020 at 19:41):

The real question is as follows: Right now, Jira prohibits regular users from making comments about issues once they've been resolved - on the grounds that such comments typically won't be seen/reviewed by anyone. (Manager users can still make comments until something is marked as applied.) Paul has proposed that we relax that constraint for "change required" issues on the premise that whoever is applying the change will see them - and can choose to act on them. However, that's only valid if we're confident that whoever applies the tracker item will in fact read the comments, as opposed to just looking at the disposition. The alternative would be for someone to petition for the tracker item to be re-opened by asking on Zulip or on the appropriate list server.

Opinions, preferences?

view this post on Zulip Vassil Peytchev (Mar 25 2020 at 20:41):

If the issue is not marked as resolved until the change is applied, would that be a better solution? It is somewhat strange that something is "resolved" but the actual change is not made.

view this post on Zulip Lloyd McKenzie (Mar 25 2020 at 21:33):

That's actually somewhat orthogonal to the question. Something gets marked as 'resolved' as soon as a resolution is present - even if that's only a proposed resolution. That's just how Jira works. In terms of the question, what really matters is the status. If something is triaged or earlier (submitted, waiting for input), then any registered user can submit comments because no decision has yet been made. Once a decision has been made (Duplicate, Deferred, Resolved No-change, Resolved Change Required), then the work group no longer looks at the item - unless the item gets re-opened, or in the case of Deferred, until the item gets returned to Triaged after the next release. The question is whether it's appropriate for comments to be submitted against items where a change has been agreed but not yet been applied - which is primarily a question of whether we believe they'll be looked at.

view this post on Zulip Vassil Peytchev (Mar 25 2020 at 21:52):

What determines if JIRA issues are looked at? If setting the status to "resolved" means that notifications are not being sent any more, then there is no way to make sure that new comments are looked at. If a status of "resolved" with "change required" still sends notifications to all who are following the JIRA issue, (including making sure that getting to such a state requires that the issue is assigned to a specific person, presumably the one who will make the change), then it is very likely any comments will still be looked at.

view this post on Zulip Lloyd McKenzie (Mar 26 2020 at 04:44):

The status being 'resolved' shouldn't be impacting notifications

view this post on Zulip Lloyd McKenzie (Mar 26 2020 at 04:44):

Though there's an issue with notification behavior that I need to dig into

view this post on Zulip Lloyd McKenzie (Mar 26 2020 at 04:45):

The reality is that very few people have the bandwidth to monitor notifications for all issues in their WGs - the only folks who will see them is those who are actually 'following' the issue - which may not include anyone from the responsible WG.

view this post on Zulip Vassil Peytchev (Mar 26 2020 at 12:50):

Is it unreasonable to require that the status of "resolved" - "change required" will have the issue assigned to someone (to actually make the change)? And then make sure notifications go to that person in addition to the "followers".
Another (additional) approach is to provide a report that shows if any "resolved" issues have new comments.

view this post on Zulip Lloyd McKenzie (Mar 26 2020 at 15:20):

It's definitely unreasonable. It's very rare that when a WG votes and agrees to a change that they'll have a clue who will do the work (or when).


Last updated: Apr 12 2022 at 19:14 UTC