Stream: cds hooks
Topic: Sandbox dependencies
Josh Mandel (Aug 28 2019 at 00:21):
I just spent _way_ too many hours updating dependencies for the sandbox with only modest success. I'm stuck on what seems to be an intermittent issue with Cerner's "terra" plugin
ERROR in ./node_modules/terra-base/node_modules/terra-i18n/lib/intlLoaders.js Module not found: Error: Can't resolve 'intlLoaders' in '/home/jmandel/work/sandbox/node_modules/terra-base/node_modules/terra-i18n/lib'
I've read https://github.com/cerner/terra-framework/issues/137 and updated to the latest terra-base and terra-i18n but am still seeing this. @Dennis Patterson any experience with this? (FYI @Carl Anderson )
Meanwhile, draft PR at https://github.com/cds-hooks/sandbox/pull/114
Dennis Patterson (Aug 28 2019 at 15:16):
Thanks for starting this, Josh! I haven't played much with the terra libraries, but I can try to allocate some time this week to start digging in and see if I can help push this along
Josh Mandel (Aug 28 2019 at 15:56):
I'm consistently hitting an issue where rm -rf node_modules; npm install "fixes" the terra-i18n errors locally. I'm at a loss.
Josh Mandel (Aug 28 2019 at 16:01):
Note I'm also adding node v12 to the travis build list, since it'll become the LTS release this coming October.
Abbie Watson (Aug 28 2019 at 16:09):
Yeah, you gotta audit all those dependencies together. Needing to refresh the node_modules cache indicates a build pipeline issue. There's been a lot of movement around adopting ES6 imports and moving away from CommonJS, as well as the recent Node upgrades. And it looks like Terra requires Node>=8.9.2 <12. So, dropping down to Node v8 or v10 is probably your first step you want to take.
Josh Mandel (Aug 28 2019 at 16:12):
Hmm. I'm wondering what value we're getting from Terra at this point.
Abbie Watson (Aug 28 2019 at 16:24):
It looks like it's heading in the right direction. The architecture has the right front-end principles behind it... reusability, composability, cross-platform, etc. But as far as these sorts of projects go, they've put a whole lot of effort into duplicating what can be obtained from something like React Material UI (which has an army of volunteers). I think it's more of an issue that Cerner wants to replicate the functionality of their Java/Oracle UI used in Millennium, but written in React.
Josh Mandel (Aug 28 2019 at 16:25):
I agree -- and I don't know that the sandbox really has any special needs here -- its has only very simple forms.
Josh Mandel (Aug 28 2019 at 16:25):
(And we're not using any of the accessibility features, translations, etc.)
Kol Kheang (Aug 28 2019 at 16:47):
Terra-ui (http://terra-ui.com) isn't just for Cerner. The library has a lot of reusable components that can help anyone building a React application quickly. Yes, there are a lot of things that Terra has but the Sandbox CDS Hooks project does not need to use all of them.
Kol Kheang (Aug 28 2019 at 16:47):
@Josh Mandel I can take a look at the dependencies issues.
Josh Mandel (Aug 28 2019 at 16:49):
Okay. I've got a branch with updates to a bunch of the major infrastructure / build-time dependencies (working now on webpack).
Josh Mandel (Aug 28 2019 at 16:49):
(Though I'll note it might be easier to blow up all our build-time scripts and get on the create-react-app train.)
Josh Mandel (Aug 28 2019 at 16:50):
(The concerns with Terra likely stem from the fact that the sandbox is several versions behind; but upgrading is not trivial.)
Jeremie Osaghae-Nosa (Dec 16 2019 at 16:25):
Wondering if anyone is getting a "Cannot launch SMART link without a SMART-enabled FHIR server" message when attempting to use CDS Sandbox. Was working perfectly fine prior to a few days ago.
Dennis Patterson (Dec 16 2019 at 22:18):
Are you using the default FHIR server (https://launch.smarthealthit.org/v/r2/fhir) or another?
Dennis Patterson (Dec 16 2019 at 22:19):
Are you starting at sandbox.cds-hooks.org or launching from another site?
Last updated: Apr 12 2022 at 19:14 UTC
